The following document contains the results of Checkstyle 8.29 with https://maven.avcompris.com/checkstyle.xml ruleset. 
| Category | Rule | Violations | Severity |
|---|---|---|---|
| coding | DeclarationOrder | 4 |  Error |
FinalLocalVariable
|
2 | Error | |
HiddenField
|
3 | Error | |
| UnnecessaryParentheses | 2 | Error | |
| design | DesignForExtension | 11 | Error |
| imports | RedundantImport | 2 | Error |
| javadoc | JavadocMethod
|
11 | Error |
| misc | FinalParameters | 2 | Error |
| modifier | RedundantModifier | 2 | Error |
| naming | AbstractClassName
|
3 | Error |
| LocalFinalVariableName | 6 | Error | |
| MethodName | 48 | Error | |
| StaticVariableName | 2 | Error | |
| whitespace | NoWhitespaceAfter | 3 | Error |
| ParenPad | 13 | Error |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | DesignForExtension | Class 'UsersServiceClient' looks like designed for extension (can be subclassed), but the method 'validateUsersQuery' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UsersServiceClient' final or making the method 'validateUsersQuery' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
| Error |
design | DesignForExtension | Class 'UsersServiceClient' looks like designed for extension (can be subclassed), but the method 'getUsers' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UsersServiceClient' final or making the method 'getUsers' static/final/abstract/empty, or adding allowed annotation for the method. | 51 |
| Error |
design | DesignForExtension | Class 'UsersServiceClient' looks like designed for extension (can be subclassed), but the method 'hasUser' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UsersServiceClient' final or making the method 'hasUser' static/final/abstract/empty, or adding allowed annotation for the method. | 91 |
| Error |
design | DesignForExtension | Class 'UsersServiceClient' looks like designed for extension (can be subclassed), but the method 'createUser' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UsersServiceClient' final or making the method 'createUser' static/final/abstract/empty, or adding allowed annotation for the method. | 101 |
| Error |
misc | FinalParameters | Parameter username should be final. | 102 |
| Error |
coding | FinalLocalVariable | Variable 'username' should be declared final. | 102 |
| Error |
design | DesignForExtension | Class 'UsersServiceClient' looks like designed for extension (can be subclassed), but the method 'getUser' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UsersServiceClient' final or making the method 'getUser' static/final/abstract/empty, or adding allowed annotation for the method. | 123 |
| Error |
design | DesignForExtension | Class 'UsersServiceClient' looks like designed for extension (can be subclassed), but the method 'updateUser' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UsersServiceClient' final or making the method 'updateUser' static/final/abstract/empty, or adding allowed annotation for the method. | 144 |
| Error |
design | DesignForExtension | Class 'UsersServiceClient' looks like designed for extension (can be subclassed), but the method 'deleteUser' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UsersServiceClient' final or making the method 'deleteUser' static/final/abstract/empty, or adding allowed annotation for the method. | 156 |
| Error |
design | DesignForExtension | Class 'UsersServiceClient' looks like designed for extension (can be subclassed), but the method 'getUserMe' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UsersServiceClient' final or making the method 'getUserMe' static/final/abstract/empty, or adding allowed annotation for the method. | 166 |
| Error |
design | DesignForExtension | Class 'UsersServiceClient' looks like designed for extension (can be subclassed), but the method 'updateUserMe' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UsersServiceClient' final or making the method 'updateUserMe' static/final/abstract/empty, or adding allowed annotation for the method. | 175 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
coding | DeclarationOrder | Static variable definition in wrong order. | 59 |
| Error |
coding | DeclarationOrder | Static variable definition in wrong order. | 62 |
| Error |
coding | DeclarationOrder | Static variable definition in wrong order. | 65 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
coding | DeclarationOrder | Static variable definition in wrong order. | 71 |
| Error |
whitespace | ParenPad | '(' is followed by whitespace. | 268 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
naming | MethodName | Name 'testGetSessions_null' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 160 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
naming | MethodName | Name 'test_purge' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 36 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
naming | MethodName | Name 'test_correlationIdParam' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 29 |
| Error |
naming | MethodName | Name 'test_correlationIdHeader' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 41 |
| Error |
naming | MethodName | Name 'test_correlationId_null_null' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 55 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
naming | MethodName | Name 'test_Usermgr_can_createUsermgrUser' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 55 |
| Error |
naming | MethodName | Name 'test_Admin_can_createAdminUser' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 65 |
| Error |
naming | MethodName | Name 'test_Admin_can_createUsermgrUser' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 75 |
| Error |
naming | MethodName | Name 'test_Usermgr_cannot_createAdminUser' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 85 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
naming | MethodName | Name 'testGetUsers_null' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 103 |
| Error |
naming | MethodName | Name 'testCreateUser_me_crash' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 119 |
| Error |
naming | MethodName | Name 'testCreateUser_full_noCrash' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 133 |
| Error |
naming | MethodName | Name 'testCreateUser_null_password' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 158 |
| Error |
naming | MethodName | Name 'testCreateDuplicateUser_crash' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 182 |
| Error |
naming | MethodName | Name 'testCreateUser_getUserMe' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 203 |
| Error |
naming | MethodName | Name 'testCreateUser_getUser' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 235 |
| Error |
naming | MethodName | Name 'testCreateUser_getUsers' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 281 |
| Error |
naming | MethodName | Name 'testCreateUser_getUsers_afterCreatedAt' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 305 |
| Error |
naming | LocalFinalVariableName | Name 'users_1_2_sortByUsername' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 352 |
| Error |
naming | LocalFinalVariableName | Name 'users_1_2_sortByDate' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 364 |
| Error |
naming | MethodName | Name 'testCreateUser_getUsers_smallPagination' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 379 |
| Error |
naming | LocalFinalVariableName | Name 'users_1_2_page1' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 432 |
| Error |
naming | LocalFinalVariableName | Name 'users_1_2_page2' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 447 |
| Error |
naming | LocalFinalVariableName | Name 'users_1_2_page3' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 462 |
| Error |
naming | MethodName | Name 'testCreateUser_getUsers_betweenCreatedAt' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 477 |
| Error |
naming | MethodName | Name 'test_validQuery_start_0' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 535 |
| Error |
naming | MethodName | Name 'test_validQuery_limit_1' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 551 |
| Error |
naming | MethodName | Name 'test_invalidQuery_start_minus1' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 567 |
| Error |
naming | MethodName | Name 'test_invalidQuery_limit_0' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 575 |
| Error |
naming | MethodName | Name 'test_invalidQuery_limit_minus1' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 581 |
| Error |
naming | MethodName | Name 'test_validQuery_sortBy_createdAt' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 589 |
| Error |
whitespace | NoWhitespaceAfter | '{' is followed by whitespace. | 594 |
| Error |
naming | MethodName | Name 'test_validQuery_sortBy_m_createdAt_username' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 598 |
| Error |
whitespace | NoWhitespaceAfter | '{' is followed by whitespace. | 603 |
| Error |
naming | MethodName | Name 'test_validQuery_sortBy_role_m_role' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 607 |
| Error |
whitespace | NoWhitespaceAfter | '{' is followed by whitespace. | 612 |
| Error |
modifier | RedundantModifier | Redundant 'final' modifier. | 615 |
| Error |
whitespace | ParenPad | '(' is followed by whitespace. | 623 |
| Error |
naming | MethodName | Name 'testCreateUsers_getUsers_sortByXxx' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 649 |
| Error |
naming | MethodName | Name 'testCreateUser_authenticateSetLastActiveAt' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 810 |
| Error |
naming | LocalFinalVariableName | Name 'after_wrong_password' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 844 |
| Error |
naming | MethodName | Name 'testCreateUser_updateUser' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 879 |
| Error |
naming | MethodName | Name 'testCreateUser_updateMe_wrongRole' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 931 |
| Error |
naming | MethodName | Name 'testCreateUser_updateFullMe_nullRole' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 956 |
| Error |
naming | MethodName | Name 'testCreateUser_superadmin_update_nullRole' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 981 |
| Error |
naming | MethodName | Name 'testCreateUser_updateUser_deleteUser' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 1008 |
| Error |
naming | MethodName | Name 'testCreateUser_updateUser_incorrectRevision_1_4' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 1034 |
| Error |
naming | MethodName | Name 'testCreateUser_updateUser_incorrectRevision_2_1' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 1056 |
| Error |
naming | MethodName | Name 'testCreateUser_updateUser_correctRevision' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 1084 |
| Error |
naming | MethodName | Name 'testDelete_superadmin' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 1110 |
| Error |
naming | MethodName | Name 'testCreateUser_deleteMyself' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 1118 |
| Error |
naming | MethodName | Name 'testCreateUser_ANONYMOUS' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 1138 |
| Error |
naming | MethodName | Name 'testCreateUser_SUPERADMIN' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 1153 |
| Error |
naming | MethodName | Name 'testUpdateUser_SUPERADMIN' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 1168 |
| Error |
naming | MethodName | Name 'testUpdateullUser_ANONYMOUS' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 1188 |
| Error |
naming | MethodName | Name 'testQuery_sortBys_all' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 1208 |
| Error |
naming | MethodName | Name 'testCreateUser_preferredLang_and_TimeZone' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 1232 |
| Error |
naming | MethodName | Name 'testCreateUser_updateUserMe_preferredLang_and_TimeZone' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 1251 |
| Error |
naming | MethodName | Name 'testCreateUser_updateUser_preferredLang_and_TimeZone' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 1288 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
naming | StaticVariableName | Name 'CORRELATION_ID' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 27 |
| Error |
naming | StaticVariableName | Name 'USERS_SERVICE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 28 |
| Error |
misc | FinalParameters | Parameter username should be final. | 102 |
| Error |
coding | FinalLocalVariable | Variable 'username' should be declared final. | 102 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
coding | HiddenField | 'sessions' hides a field. | 243 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
whitespace | ParenPad | '(' is followed by whitespace. | 44 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
naming | AbstractClassName | Name 'Comparators' must match pattern '^Abstract.*$|^.*Utils$|^.*Assert$|^.*Matchers$'. | 26 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
whitespace | ParenPad | '(' is followed by whitespace. | 16 |
| Error |
whitespace | ParenPad | '(' is followed by whitespace. | 29 |
| Error |
whitespace | ParenPad | '(' is followed by whitespace. | 80 |
| Error |
whitespace | ParenPad | '(' is followed by whitespace. | 102 |
| Error |
modifier | RedundantModifier | Redundant 'private' modifier. | 136 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | RedundantImport | Redundant import from the same package - net.avcompris.examples.users3.dao.impl.MutableUserDto. | 30 |
| Error |
imports | RedundantImport | Redundant import from the same package - net.avcompris.examples.users3.dao.impl.MutableUsersDto. | 31 |
| Error |
coding | HiddenField | 'users' hides a field. | 65 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
whitespace | ParenPad | '(' is followed by whitespace. | 47 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
naming | AbstractClassName | Name 'UsersHealthCheckDb' must match pattern '^Abstract.*$|^.*Utils$|^.*Assert$|^.*Matchers$'. | 12 |
| Error |
whitespace | ParenPad | '(' is followed by whitespace. | 14 |
| Error |
whitespace | ParenPad | '(' is followed by whitespace. | 19 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
whitespace | ParenPad | '(' is followed by whitespace. | 22 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | DesignForExtension | Class 'Application' looks like designed for extension (can be subclassed), but the method 'corsConfigurer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Application' final or making the method 'corsConfigurer' static/final/abstract/empty, or adding allowed annotation for the method. | 126 |
| Error |
coding | HiddenField | 'secure' hides a field. | 144 |
| Error |
javadoc | JavadocMethod | Expected @return tag. | 163 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | DesignForExtension | Class 'ApplicationConfig' looks like designed for extension (can be subclassed), but the method 'getRDS' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ApplicationConfig' final or making the method 'getRDS' static/final/abstract/empty, or adding allowed annotation for the method. | 19 |
| Error |
whitespace | ParenPad | '(' is followed by whitespace. | 29 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
coding | UnnecessaryParentheses | Unnecessary parentheses around lambda value. | 58 |
| Error |
javadoc | JavadocMethod | Expected @return tag. | 102 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'request'. | 103 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'authorizationHeader'. | 104 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'userSessionIdCookie'. | 105 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'userSessionIdHeader'. | 106 |
| Error |
javadoc | JavadocMethod | Expected @throws tag for 'ServiceException'. | 107 |
| Error |
coding | UnnecessaryParentheses | Unnecessary parentheses around lambda value. | 109 |
| Error |
javadoc | JavadocMethod | Expected @return tag. | 134 |
| Error |
whitespace | ParenPad | '(' is followed by whitespace. | 135 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'request'. | 136 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'response'. | 137 |
| Error |
javadoc | JavadocMethod | Expected @throws tag for 'ServiceException'. | 138 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
naming | AbstractClassName | Name 'MyAbstractController' must match pattern '^Abstract.*$|^.*Utils$|^.*Assert$|^.*Matchers$'. | 8 |
Info
Warnings